Grunt needs to be run for npm release
Opened this issue · 2 comments
benwiley4000 commented
The original module is bad for npm since it specifies an AMD module name, which must match the name of the npm package, or else. Since the npm module is called pace-progress
, and the AMD module is called pace
, a bundler like browserify or webpack won't be able to resolve the dependency.
Removing that from the coffeescript file was great, but I had to run Grunt on my own fork to get it working; the built javascript files still specify an AMD module name.
Thanks 😃
graingert commented
@benwiley4000 ah ok makes sense. I'm using pace-progress in production with require('imports?define=>false!pace-progress')
so yes looks like that's the fix.