grand-mother/grand

Test Results from DC2 Prep

Opened this issue · 1 comments

Here's a list of things I've noticed while testing the raw sim to final root file pipelines:

  • t_0 is not being stored, but can be calculated as: t0 = du_second[unit number] *1e9 + du_nanosecond[unit number]
  • time_max is empty (what is that supposed to be anyway?)
  • Zhaires traces have varying lengths, although we agreed that all traces should be 4096ns long
  • time bin size needs to be stored properly - in my opinion, for each tree. Currently voltage and efield trees have traces with different lengths due to different time bin sizes

Zhaires have the correct number of traces, i think the example files you were testing on , were not updated, DC2 files are ok.

time bin size is stored in the trun of the corresponding level, in trun.t_bin_size. This is a vector with the bin size for each antenna.

trees at the same level will share the same bin size.

since from hardware we get trigger second and nanoscond, and i think it was decided to store this two variables in absolute time. t0 in absolute time or relative to the event time can be computed from those, so it was redundant. We can make a point for saving it nonetheless in trunefieldsim.

time max is indeed empty, and we can keep this issue open to remindus of that!

I also found that time_second and time_nanosecond are not being filled in either tefield, tvoltage or tadc. Its available in tshower, but we must fill that too