add activities to job interface

Question

add activities to job interface

oblonski opened this issue 6 years ago · 4 comments

This allows the user to easily retrieve job related information without always turning the job into either a service or a shipment, i.e. we get rid of a number of "instanceof Shipment" stuff.

Answer 1 · 2019-07-19T09:42:07.000Z

dd3f29b and related commits

Answer 2 · 2019-07-19T09:45:53.000Z

This and this illustrates the improvement.

Answer 3 · 2019-07-19T09:47:43.000Z

This and this illustrates the improvement.

That looks great! :)

Answer 4 · 2019-07-19T10:04:36.000Z

... and it should not break anything even though it is defined in job interface since the job interface is actually a Schummelinterface, i.e. if you want to solve a problem with jsprit, you need to either use Service or Shipment and you are not yet allowed to implement your own job - as far as I can judge it now.