graphile/graphile-engine

"last" on function connections without @sortable doesn't make sense?

benjie opened this issue · 2 comments

I think if you have a non-@sortable function that returns setof, you will always get an error if you pass a non-null value to last; therefore we really oughtn't expose last in the first place.

Alternatively we should fix it by using row_number(), but that could be expensive.

benjie commented

Note: the cursor connections spec requires that you support either forward or backward or both: https://relay.dev/graphql/connections.htm#sec-Arguments

So omitting backwards is allowed.

Marking this as high priority because it's a breaking change.