graphite-project/carbon

Python 3.9.6 causes warning about buffering for binary mode

wvolz opened this issue · 5 comments

wvolz commented

Running Carbon 1.1.8 is causing a warning when starting up under Python 3.9.6:

lib/python3.9/os.py:1023: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used

I believe the issue is caused by the "1" on this line:

carbon/lib/carbon/log.py

Line 24 in 9fad18d

self.path, os.O_CREAT | os.O_RDWR, openMode), 'rb+', 1)

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

deniszh commented

Should be addressed

JohnHay commented

I also see it on FreeBSD with python 3.8.12:

Starting carbon.
Starting carbon-cache (instance a)
/usr/local/lib/python3.8/os.py:1023: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used
  return io.open(fd, *args, **kwargs)
stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.