graphql-boilerplates/node-graphql-server

graphql-cli devdependency missing in advanced template

kbrandwijk opened this issue · 5 comments

kbrandwijk commented

It uses graphql playground as one of the scripts.

marktani commented

You run graphql create to get the boilerplate. So you already have graphql installed.

kbrandwijk commented

Then it should be removed from the typescript-advanced, that was my point of reference.

kbrandwijk commented

@marktani Actually, thinking about it, I don't agree. The person creating this using the boilerplate must have it installed already, but any team member using the output of the boilerplate doesn't necessarily have it. For that reason, I think it should be a devDependency after all.

  • 👍1
kbrandwijk commented

@nikolasburk This is also for typescript templates. They also miss this devDependency.

nikolasburk commented

Thanks for reporting this, fixed now 🙌