graphql-java-kickstart/graphql-java-servlet

Throwable is never a GraphQLError

eduarddrenth opened this issue · 1 comments

eduarddrenth commented

If I am not mistaken a throwable will never be a GraphQLError...

graphql-java-servlet/graphql-java-kickstart/src/main/java/graphql/kickstart/execution/error/DefaultGraphQLErrorHandler.java

Line 29 in cce4709

if (error instanceof Throwable) {

oliemansm commented

GraphQLError is just an interface and anybody is free to create a custom exception which also implements the GraphQLError interface. So think that's the main reason this condition exists.

I'll convert this issue to a Discussion btw.