graphql-python/gql

Tests fail out of the box.

MrSampson opened this issue · 2 comments

I wanted to make a small change, so I followed the contributing guidelines and:

make tests passes 100% but make all_tests fails on 18 tests.

Is this to be expected?

BTW, what I wanted to change is related to the aiohttp 3.9 restriction to python3.12 I'd like to change that to 3.11 since I'm unable to upgrade to 3.12 at the moment. aiohttp 3.9 is necessary due to the two CVEs that came out a month ago.

https://nvd.nist.gov/vuln/detail/CVE-2023-49081
https://nvd.nist.gov/vuln/detail/CVE-2023-49082

Thanks,
Oliver

make tests passes 100% but make all_tests fails on 18 tests.
Is this to be expected?

Yes, make all_tests run some tests on a backend out of our control. That's why they are not part of the default tests as they could be flaky and the backend could change at any time.

I made the PR #459 to fix them for now.

See your PR for your other issue.

Ah, cool. Thanks!