Add support for creating Value::Number from i32

Question

Add support for creating Value::Number from i32

Jannis opened this issue 7 years ago · 5 comments

This would be super helpful to generate instances of Value::Number for testing. I think the ideal approach would be to add impl From<i64> for Number.

Answer 1 · 2018-05-25T12:52:26.000Z

Well, maybe merging it was a mistake. The problem is that GraphQLInt is meant to be 32bit integer. So emitting large integer values might be a problem.

Answer 2 · 2018-05-25T12:53:58.000Z

Can you explain it a little bit more? Maybe From<i32> would be enough?

Answer 3 · 2018-05-25T13:47:33.000Z

I'd be fine with that but since there was .as_i64() already, I thought I'd propose the equivalent From implementation. For the purpose of creating Number values in tests, From<i32> would be sufficient.

Answer 4 · 2018-05-25T13:48:09.000Z

Happy to send a follow-up PR for it.

Answer 5 · 2018-05-26T02:31:40.000Z

Yes, let's make From<i32> . It's easier to make range of numbers wider than other way around.

(The as_i64 might also be a mistake, it was because serde_json has that function)