Can't set Header on NotFoundHandler

Question

Can't set Header on NotFoundHandler

baldrailers opened this issue 11 years ago · 6 comments

I'm trying to override the content-type for the NotFoundHandler to be in Content-Type: application/json; charset=utf-8 but it seems like its still using Content-Type: text/plain even with beforeFilter setup.

Answer 1 · 2013-11-20T17:06:43.000Z

can you post a gist with an example just to try it please?

Answer 2 · 2013-11-20T17:30:11.000Z

sorry about that. here: https://gist.github.com/baldrailers/3ff3835f943879448d3a

Answer 3 · 2013-11-21T02:49:38.000Z

thank you very much! you are right. That's because Traffic sets the 404 header when it doesn't find a handler for the current request, and after writing the header you can't write other headers. I have a quick solution but I want to test it more, I'll try to push a fix ASAP!

Answer 4 · 2013-11-21T10:10:21.000Z

@pilu sounds great man. Keep them coming!

Answer 5 · 2013-12-06T05:34:38.000Z

@pilu any word on this? thanks

Answer 6 · 2013-12-13T13:51:46.000Z

@baldrailers the issue should be fixed now. The router doesn't write the 404 status anymore if a custom not found handler is defined. You should write the 404 status in your custom handler.