Why is first parameter `src_vocab_size`?
yangdechuan opened this issue · 1 comments
yangdechuan commented
position encoding table should be (src_len, d_model). Why (src_vocab_size, d_model) here?
graykode commented
Oops.. Thanks for right catching
In Encoder src_len+1
is right, and as same tgt_len+1
in Decoder.
I will fixed as soon as possible Thanks