green6060/digicert-public-library-demo

material ui stuff

Opened this issue · 0 comments

<Typography sx={{ fontSize: 14 }} color="text.secondary" gutterBottom>

cool on material ui for having this... doesn't mean you should use it. I'd rather see h5, h1, section, aside, p and potential class names all day long.

and then in that textStyles.css file it has mediumFontSize defined. For our company we actually use a body1 and body2, subcaption1 and subcaption2 and then we define font weights, but that's going a little too complicated for this small thing. Still... showing that you have all your fonts clearly defined in 1 section is a good coding step, it also means if the style ever changes you don't have to suddenly search 50000000000 files for all the places you hard coded a style and can just change it in 1 single place and it changes everywhere like magic.