green6060/digicert-public-library-demo

app.css styling

Opened this issue · 0 comments

font-size: calc(10px + 2vmin);

So much css for a simple header. You have a header with some text in it. First off if you just want to center it you'll be simpler doing display: grid; place-items: center; instead of flex, flex-direction, align-items, justify-content etc. etc. etc. Should your header also hold the content by itself for the font? maybe this should be an h1? h5? possibly we can define some styling rules here in app.css as well. all h5 tags use this font and are this color and this size, all paragraph tags are this font this color this size, text-wrap etc. etc. Doing something like this in a defined file (which could also be better utilized as something like textStyle.css and live there, much more descriptive. Will prevent styling mishaps in the future. There are some cool things you can do with scss as well and use imports on colors and such, but that's an entirely different topic.