Wrong parameter index in PID;P command
Closed this issue · 2 comments
renatoa commented
Please check here:
https://github.com/greencardigan/TC4-shield/blob/master/applications/Artisan/aArtisan_PID/trunk/src/aArtisanQ_PID/cmndreader.cpp#L584
paramStr(1) is not the profile number, but the P command
Should be paramStr(2)
greencardigan commented
This command was originally intended to be used as per the documentation PID,Px. The code is still wrong in this case too.
However, I think it makes sense to change it to PID,P,x so it is consistent with the other command formats.
greencardigan commented