Improperly libcurl version check.
Lebensgefahr opened this issue · 1 comments
In the README.md of plcontainer it was written the following:
PL/Container needs libcurl >=7.40. If the libcurl version on your system is low, you need to upgrade at first. For example, you could download source code and then compile and install, following this page: Install libcurl from source. Note you should make sure the libcurl library path is in the list for library lookup. Typically you might want to add the path into LD_LIBRARY_PATH and export them in shell configuration or greenplum_path.sh on all nodes (Note you need to restart the Greenplum cluster).
In Makefile the version is checked with curl-config --version. It is not correct.
For example:
In Centos 7.7.1908 there is curl with version 7.29.0 it has libcurl = libcurl.4.3.0.so static library. Of course curl-config writes libcurl 7.29.0
In curl with version 7.43.0 I've compiled from sources libcurl.4.3.0.so too.
But in 7.47.0 there is libcurl.4.5.0.so
As far as i know libcurl.4.3.0 from version 7.29.0 and libcurl.4.3.0 from version 7.43.0 are the same shared objects . At least they are compatible.
plcontainer.so just dynamically linked with that static library.
It means that I can use plcontainer 2.1.0 with curl versions at least between 7.29.0 and 7.43.0. But Makefile restricts that.
There is no libcurl 7.40 in centos 7.7.1908 and it is not guaranteed that it will appear.