gregmuellegger/django-autofixture

`post_process_instance` and instance saving order. Also bug with `UserFixture`.

AndreiPashkin opened this issue · 1 comments

Current implementation of post_process_instance implies that user, that would override it must save manually modified instance inside method of child class.
But actually Im not sure - is it really intended by author to be as that. Old documentation documentation says that this method should return "modified instance" in "last possible moment" which might mean moment before saving.
post_process_instance in UserFixture illustrates what Im talking about, take a look, with this implementation any modifications done by post_process_instance will be lost during creation, including password, because instance not being saved.

I hope to addressed this issue in your interest. I clarified the docs and made the UserFixture.post_process_instance work as advertised.