gregrahn/tpcds-kit

error in query77a

gregrahn opened this issue · 4 comments

As of v2.4 query77a is missing cr_call_center_sk in the select list and group by making it semantically different

query77a

 cr as
 (select
        sum(cr_return_amount) as returns,
        sum(cr_net_loss) as profit_loss
 from catalog_returns,
      date_dim
 where cr_returned_date_sk = d_date_sk
       and d_date between cast('[SALES_DATE]' as date)
                  and (cast('[SALES_DATE]' as date) +  30 )
 ),

query77

cr as
 (select cr_call_center_sk,
         sum(cr_return_amount) as returns,
         sum(cr_net_loss) as profit_loss
 from catalog_returns,
      date_dim
 where cr_returned_date_sk = d_date_sk
       and d_date between cast('[SALES_DATE]' as date)
                  and (cast('[SALES_DATE]' as date) +  30 days)
 group by cr_call_center_sk
 ), 

Fixed in this repo via 17d24b5.

Present in v2.4.0

Present in v2.6.0

Fixed in v2.9.0

$ diff v2.8.0rc4/query_variants/query77a.tpl v2.9.0rc2/query_variants/query77a.tpl
76,78c76,78
<  (select
<         sum(cr_return_amount) as returns,
<         sum(cr_net_loss) as profit_loss
---
>  (select cr_call_center_sk
>          sum(cr_return_amount) as returns,
>          sum(cr_net_loss) as profit_loss
84c84
<  ),
---
>  group by cr_call_center_sk),