Subpackage eslint-plugin-jsdoc version not compatible with node 18+
Closed this issue · 9 comments
Hey Greg, that is more of an FYI ticket
Thanks for this! If I have time next week, I'll try to take a deeper look to see what needs to be done to push this forward. I think the blocker right now is the extent of the code changes required to make the update absent configuration changes.
@scheinercc I've spent some more time looking into this, and I'm beginning to wonder if this will end up being a choice between supporting either @wordpress/eslint-plugin or the latest LTS version of Node, at least for the medium term. (I no longer think there's a configuration option that will prevent changes throughout Gutenberg as a consequence of this version change, but I'd love to be proven wrong.)
I suspect I'd come down on the side of supporting more recent versions of Node, and basically following this proposal:
What do you think?
I suspect I'd come down on the side of supporting more recent versions of Node, and basically following this proposal:
Sounds good to me. I support Greg's reasoning as well and am more used to the default Prettier styling for JS anyway. Thanks for looking into it!
Okay, great! I was thinking of simply swapping plugin:@wordpress/eslint-plugin/esnext for eslint:recommended as the value for extends and letting people add plugins as their project demands.
Do you see any issues with that approach?
Do you see any issues with that approach?
Nope.
I'm hoping to move forward with this later this week!
I finally got around to making this change:
I'm going to close this issue, but if you have any feedback, please let me know!
Awesome. Thanks Greg!
You're very welcome—thanks again for reporting the issue!