gregwebs/Shelly.hs

Flag `lifted` is broken --- remove?

Opened this issue · 0 comments

The package has flag lifted to "run the tests against Shelly.Lifted":

Shelly.hs/shelly.cabal

Lines 98 to 100 in 4fe64d6

Flag lifted
Description: run the tests against Shelly.Lifted
Default: False

However, this probably hasn't been used in a long time. It is actually broken:

$ cabal build -f+lifted --enable-tests
Build profile: -w ghc-9.2.1 -O1
In order, the following will be built (use -v for more details):
 - shelly-1.9.0 (test:shelly-testsuite) (file test/src/TestInit.hs changed)
Preprocessing test suite 'shelly-testsuite' for shelly-1.9.0..
Building test suite 'shelly-testsuite' for shelly-1.9.0..
[ 4 of 15] Compiling RunSpec          ( test/src/RunSpec.hs, /Users/abel/bin/src/Shelly.hs/dist-newstyle/build/x86_64-osx/ghc-9.2.1/shelly-1.9.0/t/shelly-testsuite/build/shelly-testsuite/shelly-testsuite-tmp/RunSpec.o ) [flags changed]

test/src/RunSpec.hs:26:23: error:
    Variable not in scope: onCommandHandles :: t6 -> m0 T.Text -> Sh a9
   |
26 |       res <- shelly $ onCommandHandles (initOutputHandles (flip hSetBinaryMode True))
   |                       ^^^^^^^^^^^^^^^^

test/src/RunSpec.hs:26:41: error:
    Variable not in scope: initOutputHandles :: (Handle -> IO ()) -> t6
   |
26 |       res <- shelly $ onCommandHandles (initOutputHandles (flip hSetBinaryMode True))
   |                                         ^^^^^^^^^^^^^^^^^

test/src/RunSpec.hs:35:23: error:
    Variable not in scope: bash :: t5 -> [a7] -> Sh a8
   |
35 |       res <- shelly $ bash "echo" [ "wibble" ]
   |                       ^^^^
... ((ETC))

Should we remove it or let it keep rotting?