greizgh/vaultwarden-debian

build.sh can't patch dockerfile

valantur opened this issue · 2 comments

valantur commented

Hi and thank you for your work on this project.
I'm having the following issue when trying to run build.sh:

Already on 'master'
Your branch is up to date with 'origin/master'.
/root/bitwarden_rs-debian
File /root/bitwarden_rs-debian/git/Dockerfile is not a regular file -- refusing to patch
4 out of 4 hunks ignored -- saving rejects to file /root/bitwarden_rs-debian/Dockerfile.rej

Can you please tell me what could be wrong? I'm on Debian Buster and have installed all dependencies.

Thanks!

greizgh commented

Hi and thanks for reporting this issue!
Upstream repo has evolved, the Dockerfile from project root is now a symlink.
Patchfile need to be updated as well but then it won't work for previous version...

I'm not sure the current way of patching the dockerfile is the way to go. It is definitely not future proof, we might as well have a dockerfile per version.

greizgh commented

Patch in master is now up to date with upstream dockerfile.

  • 🎉1