gridonic/hapi

Remove non-SSL option

tjschuck opened this issue · 5 comments

Harvest will soon be removing the ability to make non-SSL API requests.

All Harvest accounts now support SSL, so the option should be removed.

@tjschuck Would you care to make a PR?

I haven't written PHP in years and am not a user of this library -- I was just letting you know about a change in Harvest's API. A PR from me would be an irresponsible hack job -- I'd just update these lines to be only $http = "https://";.

I don't know if that's sufficient (probably not? looks like there's also a setSSL option which would then be ignored), or how to test it, so... someone else should probably make a better PR with more guarantee of quality.

Sorry!

No worries, thanks for letting us know anyway @tjschuck Much appreciated.

Added in #9

Thanks @peschee and @bjornpost! ❤️ ❤️ 😻 ❤️