Rename `GenericArtifact` to `Artifact` and use as parent class for other `Artifact`s
Closed this issue · 2 comments
- I have read and agree to the contributing guidelines.
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The reasoning against Artifact was that it was inconsistent with other naming patterns in the framework (context here). While this is mostly true, we've got an abstract BaseStructureConfig and a concrete StructureConfig. So we need to pick a direction and be consistent with it.
Separately, I'm not sure we should necessarily change the parent of other classes. Artifact may implement some unique logic in the future that we don't want applied to other Artifact types.
After some discussion with @vasinov, we've decided to keep GenericArtifact and bring ConversationMemory and StructureConfig in-line with a similar naming convention.