grislyeye/three-meet

Sidebar does not disappear when clicking outside page

Closed this issue · 7 comments

Sidebar does not rollback when users are clicking outside the page content, in the gap between the content and the bottom and right-side of the screen.

That is, in the red border seen here:

Screenshot 2022-09-03 at 19 15 12

Idk if you fixed this or not, but only in the Combat Rules page it does not work, on the rest works fine.

I think it's happening on any page where the content doesn't exceed the view height. For example:

https://three-meet.grislyeye.com/#/pages/backgrounds/index

@abitsalihu is this happening for you in your browser for the above page?

@rg-wood It is happening, I went into dev mode and put a border to the section part and it appears that if you click on the section part the nav will close, but if u click outside of the section part the nav will not respond to it, so maybe just increase the height of the section? Or check to add an event listener somewhere else

Screen Shot 2022-09-04 at 12 55 56

@abitsalihu I agree. On my to-do list. Thanks for verifying.

@rg-wood I managed to fix it in this particular page, if u want u can assign me this problem.

@abitsalihu Sure. Send me a PR and I'll review it ASAP.