Calendar widget not useable when external CDNs are down
Opened this issue · 5 comments
Describe the current behavior
I just started a docker container to try out grist. After adding a calendar widget I got a blank page for the widget; this is currently happening because unpkg seems to be (partially?) down:
It would be really great if the widgets that are shipped inside grist directly did not rely on external CDNs
Steps to reproduce
Create a calendar widget and observe requests to unpkg failing (at least as off now)
Describe the expected behavior
Calendar widget should load.
Where have you encountered this bug?
- On docs.getgrist.com
- On a self-hosted instance
Instance information (when self-hosting only)
No response
Thanks for reporting. In principle this should have been done for grist-core, I guess the behavior has rusted?
#745
No idea? I mean is templates.getgrist.com using grist-core? Because it occurs there as well: https://templates.getgrist.com/uqUVorrMc23r/Field-Trip-Planner/p/9
Oh @paulfitz the calendar is avalaible in the sense that it is visible in the UI, but it doesn't load because it's index.html uses external resources: https://github.com/gristlabs/grist-widget/blob/685aaa326c57f239a65f1b998355d1ae3df9b15a/calendar/index.html#L70-L73 (among others). I am not sure how the bundling would help there unless the npm packaging of grist-widgets gets rid of those.
EDIT:// Also Toast UI seems to be kinda unmaintained?
I am not sure how the bundling would help there unless the npm packaging of grist-widgets gets rid of those.
Yes, that's exactly what it does - crawls them, rewrites links, bundles everything up. If you build Grist you can see the material living in node_modules/@gristlabs/grist-widget/. We're looking into it. Was working in the past, is not working today.
Ah that makes sense. I have looked into the container and it looks like it is shipping the bundled data:
So the problem is not the grist-widget module but grist-core itself because it still loads the index.html for github directly: