grommet/grommet-addons

Sort component controls are visually ambiguous

Opened this issue · 2 comments

phazor commented

The current Sort component has visually ambiguous icons for 'ascending' and 'descending' states. Furthermore, various popular websites seem to disagree on which way to point the arrow buttons for a given sort order.

Google Drive is one notable webapp that takes the opposite view of Grommet: the arrow points up for ascending and down for descending.

A simple solution is to use grommet's 'ascend' and 'descend' icons, as they provide additional context. Tooltips should also be added.
screen shot 2017-09-15 at 10 31 16 screen shot 2017-09-15 at 10 31 04

I'm happy to provide a PR for this if you can confirm that it will be reviewed 🙂

L0ZZI commented

Of course it will be reviewed. Going forward in Grommet v2, we've simplified the input controls. I personally feel like we don't need an icon. I agree it's too confusing. Let us know if you're still interested.

RobertGary1 commented

I've had several people tell me my app is backwards because I'm using this as well. When you pass 'desc' the up arrow is highlighted. No way to fix this here without breaking everyone though.