Calendar - fontSize is ignored
jcfilben opened this issue · 4 comments
In the Calendar section of the theme we are setting specific values to use for the font size of the dates at different sizes of the Calendar. However these values are being ignored and different values are coming through for the font size. It also seems strange that we would defined sizes like '13.6px' rather than using our text t-shirt sizes.
Small size calendar in hpe theme:
The font sizes seem a bit odd because they are being fit to 1/7 of the width of the Calendar. So, the Calendar width is driven by the t-shirt sizing of content width and then the font is proportional to that based on a week having seven days.
The font size is ignored bc of the extend we have in Button. The font needs to be a minimum of 19px so that the selected calendar day is accessible on brand green (another instance where the brand green being difficult re: color contrast hurts on the design side). Open to discussing options though.
Since we are not using it should we remove the Calendar font size definition from the hpe theme?
It might be worth having a small design discussion just so everyone is on the same page with what's going on. (not sure if we show sizes in Figma).
But given other priorities, I think the immediate best step would be to remove that block or add a comment above the block saying why it's not coming through.