Upgrade transitfeed library and remove feed_info workaround

Question

Upgrade transitfeed library and remove feed_info workaround

grote opened this issue 7 years ago · 6 comments

google/transitfeed#394 has been merged and released as 1.2.16.The workaround in the code to add the feed_info.txt manually should be removed now.

Also, Accra regression tests need to be fixed. There are different stop times now.

Answer 1 · 2018-01-24T12:23:16.000Z

A new version has been released: https://pypi.python.org/pypi/transitfeed

The work-around should be removed now and we should depend on the latest version.

Answer 2 · 2018-01-24T19:56:45.000Z

@nlehuby or @prhod when you get a chance, could you please look into why the transitfeed upgrade changes your gtfs zip and maybe package a new one for now?

Answer 3 · 2018-01-25T16:57:47.000Z

HI @grote ! I'll try to have a look soon. Note to self : only the stop_times.txt file is different.

Answer 4 · 2018-01-26T15:24:16.000Z

Looking further, I have differences in stop_times. For example, trip_id 82 takes 15' from end to end and the expected travel time is 2 hours. I still need to investigate.

Answer 5 · 2018-01-27T19:57:34.000Z

I don't know why I had differencies before, I don't have anymore. Maybe I mixed up my working files ...
Anyway, I made the PR #122 to upgrade to the last version of Transitland. The only difference was the addition of the "timepoint" column in the stop_times.txt file.

Answer 6 · 2018-03-01T05:55:04.000Z

The associated PR has been merged. Can this issue be closed, @grote? Thanks!