Partial registration happening before namespace defined

Question

Partial registration happening before namespace defined

Closed this issue 9 years ago · 14 comments

lostthetrail commented 10 years ago

Since 0.9x partials are registering before their namespace is defined.

pivotal-vanguard commented 9 years ago

bump

Answer 1 · 2014-12-08T18:53:25.000Z

Problem is same as described in #122. Though I don't feel like the solution provided is correct.

Answer 2 · 2014-12-08T18:54:24.000Z

@vladikoff What is the process to get this PR reviewed and merged? It was opened in October.
Thanks!

Answer 3 · 2014-12-08T21:30:05.000Z

It appears to be a bit less straight forward than just a flag not being respected. Digging in some more.

Answer 4 · 2014-12-08T21:40:34.000Z

OK, the problems occurs when you have partials namespaces and you have multiple templates, with at least one of them ordered before the partials in the configuration.

Answer 5 · 2014-12-08T21:42:45.000Z

Example below:

      partials_use_namespace_multiple_templates: {
        options: {
          partialsUseNamespace: true
        },
        files: {
          'tmp/partials_use_namespace_multiple_templates.js': ['test/fixtures/has-spaces.hbs',
            'test/fixtures/_partial.hbs', 'test/fixtures/one.hbs']
        }
      },

Answer 6 · 2014-12-08T21:43:51.000Z

Will result in the follow generation:

partial registration
namespace declaration
helper registration

Answer 7 · 2014-12-08T23:47:11.000Z

@lazd This issue relates to work done in commit 373d402

Answer 8 · 2014-12-09T00:24:28.000Z

A stop-gap for anyone running into this is to pre-order your partials in-front of your templates in your configuration.

Answer 9 · 2014-12-09T23:40:42.000Z

Going through CLA right now and will have a PR shortly.

Answer 10 · 2015-02-05T16:43:20.000Z

Fixed and released as grunt-contrib-handlebars@0.9.3.

Answer 11 · 2015-02-05T16:52:25.000Z

@pivotal-vanguard This should be solved at 0.9.3

Answer 12 · 2015-02-23T14:25:39.000Z

This is still causing me problems as of 0.9.3. I am running Handelbars 2.0.0 with grunt-contrib-handlebars 0.9.3

Answer 13 · 2015-02-23T15:21:35.000Z

@dylanrhysscott can you put together a small test case and provide the output you're getting so we can troubleshoot it?

Also, please triple check your installed version. Thanks!