gslab-econ/template

Implement 4.0 test comments for template

lboxell opened this issue · 2 comments

lboxell commented

See [template task]'s in gslab-econ/gslab_python#58 (comment)

Combined meeting notes:

Meeting note

  • Echo command for user-config.yaml. [Template task]

  • Allow stata-flavour yaml to be empty. Change stata-flavour to stata-exec. Make comment that Windows user can specify StataMP-64.exe. [Template task]

  • Prompt user input for yaml file if it does not exist. [Template task]

  • setup.py script name is not ideal in template (setup.py means something in the general Python context) [Template task]

  • drop default support for gslab mtheme [Template task]

  • It's not clear to me why we force the user to have a cache. We should at least discuss that if we make them write it into their user-config. (we decided to drop this as default requirement and add it as part of the "extra features" section in the readme.md) [Template task]

  • Remove demonstration of Stata/R, add it to FAQ (build_stata vs build_python) so forth [template task]

  • check_cache(cache_dir) [template task]

  • The entire error message in check_cache is not printed when there's an error. [template task]

  • fix use of ~ [template task]

  • don't produce .pyc [template task]

  • remove references to mode=release [template task]

  • GSLab specific import statement should be kept together at the top of the SConstruct. [template task]

lboxell commented

See #45

M-R-Sullivan commented

Summary

  • This issue passed PR in #45.
  • Implemented miscellaneous changes to the template as listed here.
  • Standardized stata_executable as name for the user's Stata executable in gslab_python in gslab-econ/gslab_python#67. We also standardized it in template.