gsoft-inc/sg-orbit

❗ Activate missing testling-library and jest eslint rules

Closed this issue · 0 comments

Description

Some eslint rules had to be disabled because they were causing warnings in our codebase. It would be nice to fix the issues:

            "jest/no-commented-out-tests": "off", // TODO remove this when we fix all commented out tests
            "testing-library/no-unnecessary-act": "off", // multiple errors, should be fixed in another PR. 515 errors
            "testing-library/prefer-screen-queries": "off", // multiple errors, should be fixed in another PR. 1343 errors
            "testing-library/prefer-find-by": "off", // multiple errors, should be fixed in another PR. 135 errors
            "testing-library/no-node-access": "off", // multiple errors, should be fixed in another PR. 37 errors
            "testing-library/prefer-presence-queries": "off" // multiple errors, should be fixed in another PR. 21 errors

Checklist:

  • jest/no-commented-out-tests
  • testing-library/no-unnecessary-act
  • testing-library/prefer-screen-queries
  • testing-library/prefer-find-by
  • testing-library/no-node-access
  • testing-library/prefer-presence-queries