gtt-project/redmine_gtt

Upgrade rgeo to v3.0.0

sanak opened this issue · 1 comments

sanak commented

Problem
Currently, invalid geometry test fails in GitHub Actions,
#209

and the cause seems to be recent rgeo major version up (2.4.0 -> 3.0.0).
#209 (comment)

Improvement
I am thinking to do followings limit rgeo version to 2.4.0 as workaround, but upgrading rgeo to v3.0.0 is necessary afterwards.
https://github.com/rgeo/rgeo/blob/main/doc/Upgrading-to-v3.md

dkastl commented

Upgrading seems to be no problem except of this test, that should validate geometries, so for now I commented it out in another branch
2a55ce3

Not sure what we actually want to declare as "invalid", but the existing MultiPolygon was actually possible to be uploaded as JSON, so eventually it was valid.

With a completely invalid geometry the return value of the validation seems to have changed. Maybe all this can be improved anyway.