Display newlines properly
Closed this issue · 10 comments
Currently multi-line subtitles are displayed on a single line; linebreaks are ignored. Sample SRT subtitle file that demonstrates this: test-multiline-subtitles.zip (in a ZIP archive, as GitHub won't let me upload it otherwise; I have enclosed a simple blank MP4 file, but any video will do).
The lines should be displayed like this:
- Line #1
- Line #2
But they are displayed like this:
Fixed issue. Checkout the master branch of my fork. Also, there seem to be a lot of missing lib files. Download them separately on your own to get things to work. For example, captions wont work unless you have the zip.js files in src/lib/zip.js.
@vivekannan would you care to prepare a release that could be installed in Chrome OS straight away? I installed from https://chrome.google.com/webstore/detail/subtitle-videoplayer/naikohapihpbhficdpbddmgbhiccijca and would not have the first idea how to install on Chrome OS from source, or if it is even possible.
I don't have owner access to that extension. I will ask @guancio to update the webstore with the fix. I tried mailing him to ask if he needed help with this repository but he still hasn't replied. So you may have to wait a little longer.
I have started the pull request #44. @guancio has some work to do! ;)
How about I send you a zip file that has all the latest stuff included. I
have made a lot of changes and added some new features as well. Maybe you
can test it for me if you are a frequent user? I normally don't use chrome
OS so it is difficult for me to test it thoroughly. I will also include
instructions to load the zip as an extension.
On Thursday, June 30, 2016, Jan Minar notifications@github.com wrote:
@vivekannan https://github.com/vivekannan would you care to prepare a
release that could be installed in Chrome OS straight away? I installed
from
https://chrome.google.com/webstore/detail/subtitle-videoplayer/naikohapihpbhficdpbddmgbhiccijca
and would not have the first idea how to install on Chrome OS from source,
or if it is even possible.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#42 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AHkl-rqSxZ-nXH2CaF2q1hCb3eQV1HjDks5qQ8LGgaJpZM4HYPCm
.
Hey! I have sent an email with the zip files attached to rdancer@rdancer.org.
Not sure if you got them because it is not in my sent mails. Just checking.
On Thu, Jul 7, 2016 at 7:32 PM, Jan Minar notifications@github.com wrote:
That would be very kind of you!
No need for instructions, a zipped extension is all I need.
Let me know if there are particular areas that you'd like me to test?
Not sure if it's possible to send via Github; if e-mail is more convenient
for you:
rdancer@rdancer.org—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#42 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AHkl-uo-rpAaGTJz9CK0S3tukkD7tV-oks5qTQbpgaJpZM4HYPCm
.
Not received. Please re-send?
On Saturday, 9 July 2016, Vivek Kannan notifications@github.com wrote:
Hey! I have sent an email with the zip files attached to
rdancer@rdancer.org javascript:_e(%7B%7D,'cvml','rdancer@rdancer.org');.
Not sure if you got them because it is not in my sent mails. Just checking.On Thu, Jul 7, 2016 at 7:32 PM, Jan Minar <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:That would be very kind of you!
No need for instructions, a zipped extension is all I need.
Let me know if there are particular areas that you'd like me to test?
Not sure if it's possible to send via Github; if e-mail is more
convenient
for you:
rdancer@rdancer.org
javascript:_e(%7B%7D,'cvml','rdancer@rdancer.org');—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
#42 (comment)
,
or mute the thread
<
https://github.com/notifications/unsubscribe/AHkl-uo-rpAaGTJz9CK0S3tukkD7tV-oks5qTQbpgaJpZM4HYPCm.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#42 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AADHVLWNV92F2BvT9pB5Z-YgmduETn0Bks5qT7VGgaJpZM4HYPCm
.
I just sent it again. Could you confirm?
On Sat, Jul 9, 2016 at 10:35 PM, Jan Minar notifications@github.com wrote:
Not received. Please re-send?
On Saturday, 9 July 2016, Vivek Kannan notifications@github.com wrote:
Hey! I have sent an email with the zip files attached to
rdancer@rdancer.org <javascript:_e(%7B%7D,'cvml','rdancer@rdancer.org
');>.
Not sure if you got them because it is not in my sent mails. Just
checking.On Thu, Jul 7, 2016 at 7:32 PM, Jan Minar <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:That would be very kind of you!
No need for instructions, a zipped extension is all I need.
Let me know if there are particular areas that you'd like me to test?
Not sure if it's possible to send via Github; if e-mail is more
convenient
for you:
rdancer@rdancer.org
javascript:_e(%7B%7D,'cvml','rdancer@rdancer.org');—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<,
or mute the thread
<https://github.com/notifications/unsubscribe/AHkl-uo-rpAaGTJz9CK0S3tukkD7tV-oks5qTQbpgaJpZM4HYPCm
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
#42 (comment)
,
or mute the thread
<
https://github.com/notifications/unsubscribe/AADHVLWNV92F2BvT9pB5Z-YgmduETn0Bks5qT7VGgaJpZM4HYPCm.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#42 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AHkl-gY_MYNbmGU_nUpo9foFfdfi-9Hpks5qT9TzgaJpZM4HYPCm
.
No. Not in spam either. Can you attach it here or upload somewhere & paste a link to it?
Oops! Never received you last comment. A newer version of the app is now available at the chroome store. Your app should automatically update. Feedback would be valuable.