guancio/kth-on-rpi2

Potential bug in guests_init

Opened this issue · 1 comments

In init.c, in the function guests_init, you appear to loop through one extra MiB of memory when creating the one-to-one mapping of the guest memory (just below the comment "this must be a loop" around line 225). At this line, we also have the comment /+ 1 MiB at end for L1PT/. In loops on similar memory ranges below, you do not loop through extra memory. What made this stand out was also that the person who wrote the code had added SECTION_SIZE on both sides of the for-loop condition. Seems like a typical oversight...

When Roberto tried to run the hypervisor with Linux on the Beagleboard simulator with the same memory range in the loop as in the other loops, everything seemed to work fine...