guardian/source

Additional icons for apps-rendering

Closed this issue · 7 comments

We are still using an icon font in apps-rendering but would like to use the SVG icons in source.

There's some icons missing we would need before fully removing that icons font:

  • Camera
  • Stars
  • Quote
  • Comment

I've got a Figma file with these SVGs so I could make a PR to add them, would this be useful?

Screen Shot 2020-05-28 at 11 45 58

Screen Shot 2020-05-28 at 11 46 20

Screen Shot 2020-05-28 at 11 45 40

Quote

Out of curiosity, which one are we talking about? There were so many…

We're using this one on apps

IMG_5297

Thanks @webb04 . We have the camera, star and comment icons in Figma already, we just need to add React versions of the SVGs to the svgs and icons packages.

The quote icon is interesting, it seems like it belongs in Editorial Source. Should we create an editorial icons package?

c/c @gtrufitt @oliverlloyd @liywjl @JamieB-gu

I think there's a reasonable chance of the quote icon showing up elsewhere, e.g. Reader Revenue. It's currently in a few places on the Patrons site for example.

@JamieB-gu that's good to know, thanks!

@webb04 If you could share the quote icon, I'll add it to Figma, and then to the Source repo and the Source website ☺️

I found this in one of @benwuersching 's designs

quote.svg.zip

Thanks for sharing the file @webb04. Sorry, I got a bit carried away and implemented these additions myself 🙄

Please let me know if there's any issue.