guardian/source

Inclusion of new gift icon

Closed this issue · 3 comments

GHaberis commented

We've had to introduce a new svg gift box icon into the main navigation for "gifting" on frontend and dotcom-rendering, it'd be good to get this in source. Can I just raise a PR to include it?

Screenshot 2020-12-21 at 11 51 02

SiAdcock commented

Thanks for raising this @GHaberis. I'll discuss this with @akemitakagi when she's back in the office. The icon is not currently in our Figma library, so we'll need to add it or consider alternatives. When we have an icon in Figma, we can add it to the codebase – your help in doing this will be greatly appreciated 😍

I'll get back to you tomorrow.

SiAdcock commented

@akemitakagi will work with designers to ensure this gets added to Figma.

@GHaberis would you be able to raise a PR adding it to the icons package? 🙏

UPDATE: please hold off making any changes for now. We are still checking the icon is correct, we will update you tomorrow
UPDATE 2: we are tweaking the icon. We'll provide another update when it's ready for release