guelfoweb/peframe

Please use consistent license

satta opened this issue · 2 comments

satta commented

It looks like the license headers still show different licenses, some GPL:

$ git grep -l 'GNU General Public Licen'
peframe/modules/dump.py
peframe/modules/info.py
peframe/modules/loadfile.py
peframe/modules/pecore.py
peframe/modules/secalert.py
peframe/modules/stdoutput.py
peframe/modules/strings.py

and some MIT:

$ git grep -l 'The MIT'
peframe/modules/antivm.py
peframe/modules/apialert.py
peframe/modules/apiantidbg.py
peframe/modules/apimutex.py
peframe/modules/cert.py
peframe/modules/directories.py
peframe/modules/directory.py
peframe/modules/fileurl.py
peframe/modules/funcexport.py
peframe/modules/funcimport.py
peframe/modules/help.py
peframe/modules/meta.py
peframe/modules/peid.py
peframe/modules/resources.py
peframe/modules/sections.py
peframe/modules/stringstat.py
peframe/modules/virustotal.py
peframe/modules/xor.py
peframe/peframe.py

Since setup.py declares MIT as the package license, I would appreciate of the license would be made consistent. From a Debian packager's point of view, it would also be beneficial (while not absolutely required) to have a proper LICENSE file in the root directory.

abenson commented

Additionally, the licenses that were in the files are now also missing.

abenson commented

From a Debian packager's point of view, it would also be beneficial (while not absolutely required) to have a proper LICENSE file in the root directory.

From a Void Linux packager's point of view, the MIT license absolutely must be distributed with the source. It was okay before when it was available in the file itself, but it appears to have been removed completely.

  • 👍1