guidokessels/xwing-data

Use consistent HTML

Closed this issue · 4 comments

bmds commented

There is a mixed use of <strong>, <b>, <em, and <i> throughout the text

E.g:
Ion Cannon Turret uses <strong> while Cloaking Device uses <b>
Hound's Tooth uses <em> while Phantom uses <i>

I've not noticed any mixed use within one piece of text. It is easy to pick up however when converting from HTML to another syntax it adds an extra wrinkle.

guidokessels commented

Thanks, it should be consistent. I'll fix it.

Just curious; What're you converting it into?

bmds commented

I'm displaying the text in Slack which has a format similar to Markdown:
https://get.slack.help/hc/en-us/articles/202288908-Format-your-messages

HTML is easy enough to convert from to be a non issue

lvisintini commented

Should we use <strong><em> or <b><i>?
<b><i> are shorter and imply styling which would match the cards text styles.

<strong><em> are style agnostic and could look different depending on the platform used, but perhaps they match better the intent of using bold or italic in the cards to begin with

guidokessels commented

@bmds Fixed! Thanks for reporting :)