guidopetri/chess-pipeline

Get multiple perftypes

Closed this issue · 3 comments

Another update to the lichess API is that we can request several perftypes at once. This is probably better - however, the "time_control_category" attribute relies on the perftype specified, so this needs to be looked into.

Looks like if multiple perftypes are specified, then we can't tell from the PGN data what speed a game is played at, but it works from the JSON data. So this is another case of requiring yet another API request...

It also means another Task for Luigi to take care of, and more work to integrate the two Tasks.

Done with 0dc72d5 . Testing now, but finding some bugs when local_stockfish is not a requirement. Heheh.

Looks like this works now!

I really should work on some sort of testing framework soon so I can catch stuff like what happened here.