GHC_NO_DIRENT_D_TYPE should be defined on Haiku
Begasus opened this issue · 6 comments
Describe the bug
Filesystem fails to compile (filesystem/filesystem.hpp) on Haiku because of missing d_type in dirent structure.
Additional context
doxygen/doxygen#9610
This is a valid solution for the used version ghc::filesystem v1.5.6, but with #142 this is not needed any more, as starting with v1.5.12 the code detects the presence of dirent.d_type automatically at compile time.
Could still use the detection for Haiku, otherwise I'm getting: error "Operating system currently not supported!":
From: https://github.com/gulrak/filesystem/blob/master/include/ghc/filesystem.hpp#L79
#elif defined(__QNX__)
#define GHC_OS_QNX
+#elif defined(__HAIKU__)
+#define GHC_OS_HAIKU
#elseThis can be closed I think, created a stand-alone package on Haiku with the related PR here, build and install seem OK.
I'm doing a build for catch2 to see if I can run the provided tests here also, thanks so far! :)
You are right, I will add the detection.
Upstream PR merged, thanks! 👍