Modules overwriting with default
geek3dgeek opened this issue · 6 comments
When editing config files in ~/magicmirror/mounts/modules/default , they're being overwritten on reboot.
yes, thats the default behaviour of my docker setup. I changed this because I got problems with old versions of this files. In the past they were mounted outside of the container and never updated. So I decided to override them on start.
So why do you need to edit these files? I could solve this problem e.g. with an environment variable.
I can insert an env var OVERRIDE_DEFAULT_MODULES=true and copy the default modules only if this var is true. But default will be true, you have to update the docker-compose.yml yourself to set this var to false. Would this solve your problem?
With a classic install you have the same problems later. The mm project is living so with every release files are changed. You now have a working solution, but if you want to update to a new release you have to do a git pull - which will fail because of the local changes.
So my decision was to run the current version of mm with the fitting default modules files - and not with versions I got x releases before. This would also result in unnecessary support.
So I will update my docker project with an env var mentioned above and document this behaviour there. Everyone can decide then to run with the default behaviour or run with a static default modules folder on own risk.