guzba/ready

Error: 'join' can have side effects (nim 2.0)

ITwrx opened this issue · 4 comments

ITwrx commented

I get the following compile error when trying to compile with nim 2.0

/home/itwrx/.nimble/pkgs/ready-0.1.2/ready/connections.nim(55, 15) template/generic instantiation of `join` from here
/home/itwrx/.choosenim/toolchains/nim-2.0.0/lib/pure/strutils.nim(1855, 6) Error: 'join' can have side effects
> /home/itwrx/.choosenim/toolchains/nim-2.0.0/lib/pure/strutils.nim(1865, 17) Hint: 'join' calls `.sideEffect` '$'
>> /home/itwrx/.nimble/pkgs/ready-0.1.2/ready/connections.nim(46, 6) Hint: '$' called by 'join'

thanks

guzba commented

This has been fixed in release 0.1.4.

ITwrx commented

i uninstalled and reinstalled ready and i still get the following.

/home/itwrx/.nimble/pkgs2/ready-0.1.4-876e2ab213a5ef4a48f054a37cd420d1a1d2fa6c/ready/connections.nim(55, 15) template/generic instantiation of `join` from here
/home/itwrx/.choosenim/toolchains/nim-2.0.0/lib/pure/strutils.nim(1855, 6) Error: 'join' can have side effects
> /home/itwrx/.choosenim/toolchains/nim-2.0.0/lib/pure/strutils.nim(1865, 17) Hint: 'join' calls `.sideEffect` '$'
>> /home/itwrx/.nimble/pkgs2/ready-0.1.4-876e2ab213a5ef4a48f054a37cd420d1a1d2fa6c/ready/connections.nim(46, 6) Hint: '$' called by 'join'
guzba commented

Ah my mistake, it is fixed in 0.1.5 which I had not tagged yet. Just tagged now.

ITwrx commented

great! thanks