gwillem/magento-malware-scanner

md5_to_incoming.sh - still used?

Mooey28 opened this issue · 0 comments

Is md5_to_incoming.sh still to be used? The current contributing docs skip straight to placing your sample into corpus/backend or corpus/frontend - but I don't see where the file will be renamed with its hash following this currently method?

I suggest updating CONTRIBUTING.md to merge how it was a short whole ago (i.e. the use of md5_to_incoming.sh script) with what the current process is, and alter the md5_to_incoming.sh to place the file into either frontend of backend depending on whether its PHP or JavaScript - perhaps two different scripts would be simpler?

So the docs could then read someting like - place sample into corpus/incoming and run tools/frontend_md5_to_incoming.sh for JavaScript and tools/backend_md5_to_incoming.sh for PHP. The script will then calculate MD5 hash and rename, and move the sample to the appropriate folder in corpus.