gyng/save-in

[Firefox] stopped saving files

despecial opened this issue ยท 14 comments

Worked like a charme but today, after a restart of the browser Firefox is unable to save items via the plugin.
Notification only says "Crash" and download fails. Enough space is there and the symlink is working.

Any idea?

After checking other websites it seems that Instagram changed their url scheme or something else is interrupting the plugin. Other sites work as before - instagram.com is failing. @gyng

Is this abandonned software? Would be a pity! @gyng

gyng commented

Apologies, real life is in the way :(

I'll try to spare some time in the near future to go through the backlog real soon.

It's been a month - did you find some time to check the problem?

gyng commented

I tried downloading from Instagram and it indeed crashes with CRASH. I believe it's a browser bug, this seems to be it: https://bugzilla.mozilla.org/show_bug.cgi?id=1633191

I've added a workaround that seems to fix it on my machine on FF Nightly in b361b1a.

I also noticed Instagram has a div covering images, so you'll need to block that div using an adblocker to get the context menu working.

Thanks for the report! I appreciate that it took a while for me to look into this. Hopefully this fixes it for Instagram images with 3.5.2.

gyng commented

Unfortunately, after more testing the bug is back: maybe I got lucky somehow. For now I can only suggest using Chrome if the bug isn't fixed.

gyng commented

Some good news, though. I added a "Fetch via Fetch API" option that should work for Instagram. It should come with the next release.

image

gyng commented

This option is in 3.5.3. It's not enabled by default, so you'll need to switch it on.

What are the drawbacks, if any, to this Fetch API? I noticed I can save Pixiv images to two folders without having to refresh the page. I never enabled that script method because I didn't want to lose notifications.

gyng commented

@SenpaiSharp Thanks for the report that it works for Pixiv. It's a fresh download of the image. I'm not sure if it passes cookies and referral headers (I didn't test), so the site could block downloads based off that.

One drawback e.g. is that saving videos from IG takes up to 20-30s. So you wont see if FF is downloading it until its shown in the "downloads" list.

In firefox forks this does not work (option not available)

on FireDragon
screen