Change hosts file format
Closed this issue · 7 comments
GoogleCodeExporter commented
As suggested in issue 7, I think it should be better to have the following
format in the hosts file :
[user@]host[:port]
instead of :
host[:port] [user]
I think it's more "natural", and would be more consistent with the new
output file names (see issue 7).
Thanks in advance,
Marc
Original issue reported on code.google.com by dooblem...@positon.org
on 22 Feb 2010 at 10:35
GoogleCodeExporter commented
I agree that this would be a better format, but to start with, we'll need to
support
both syntaxes (before deprecating the old syntax). This isn't a really high
priority
issue, but I agree that it would be an improvement. I'll get to it eventually,
but it
will probably be in PSSH 2.2 rather than PSSH 2.1.
Original comment by amcna...@gmail.com
on 22 Feb 2010 at 5:47
- Changed state: Accepted
- Added labels: Priority-Low
- Removed labels: Priority-Medium
GoogleCodeExporter commented
I've implemented the [user@]host[:port] in a new commit (which is _not_
included in
PSSH 2.1). Anyway, feel free to give it a try and see what you think.
Eventually, we'll need to deprecate the old line format, too, but for now the
new line
format should work. Let me know if you have any problems.
Original comment by amcna...@gmail.com
on 25 Feb 2010 at 6:00
- Changed state: Started
GoogleCodeExporter commented
Since I haven't heard back from you, I'm going to close this issue. However, it
would still be great if you could test it and give feedback. Thanks.
Original comment by amcna...@gmail.com
on 5 Mar 2010 at 3:55
- Changed state: Fixed
GoogleCodeExporter commented
Sorry.. seems I missed your comment 2 :)
I tested it : it works perfectly with no problem.
I tested both new and old hosts file format, and also check the output file
names.
All is OK.. Thanks a lot.
Original comment by dooblem...@positon.org
on 5 Mar 2010 at 9:33
GoogleCodeExporter commented
Great. I'm glad it works. Starting in PSSH 2.2, [user@]host[:port] will be
the
documented syntax for the file, and we'll probably wait a few versions to
deprecate
the old syntax. Thanks for your help.
Original comment by amcna...@gmail.com
on 5 Mar 2010 at 5:13
- Changed state: Verified
GoogleCodeExporter commented
Where is the commit mentioned for this? I seem to have missed it.
Original comment by rouss...@gmail.com
on 30 Nov 2010 at 3:56
GoogleCodeExporter commented
This is in commit bda32356.
Original comment by amcna...@gmail.com
on 2 Dec 2010 at 6:42