h5bp/mobile-boilerplate

Improvement for MBP.fastButton : do not set a "pressedClass" by default

mysegfault opened this issue · 3 comments

mysegfault commented

Hi !

With MBP.fastButton : there is a default CSS class set on the clicked element in the "onTouchStart" "onClick" and "reset" methods. This is nice but should be optional, because this take some resources (and time!) when clicking on the item, especially if you don't want to set a custom style to this clicked item. (mobile devices are first concerned for performance)

I can prepare a pull request with this change : by default, the pressedClass will be null and is only applied when the developer set it from the constructor.

Thank you for your feedback.

mysegfault commented

Oh i was saw that you switched to FT FastClick ! So this is useless now...

alexgibson commented

Thanks for reporting the issue!

Yes unless anyone comes forward with some valid reasons not to switch to FT FastClick, I plan to merge #194 sometime soon.

arthurvr commented

Yes unless anyone comes forward with some valid reasons not to switch to FT FastClick, I plan to merge #194 sometime soon.

It's merged. Let's close down this issue.