h5bp/server-configs-nginx

Validate configs with Gixy?

devinrhode2 opened this issue · 8 comments

devinrhode2 commented

I'm sure there wouldn't be any very remarkable insights from linting with Gixy, but it would certainly be nice to see that this config passes through Gixy. https://github.com/yandex/gixy

LeoColomb commented

Thanks for this suggestion @devinrhode2, this is a really good idea.
Wanna open a pull request with its usage?

rezaromiany commented

با تشکر از این پیشنهاد @devinrhode2 ، این واقعا ایده خوبی است.
آیا می خواهید یک درخواست کشش با استفاده از آن باز کنید؟

بله

rezaromiany commented

yes

  • 😄1
will-war commented

yes

helow friend let's make the good and new repositorry

will-war commented

https://bitbucket.org/account/projects/create
use this text me when you get it

devinrhode2 commented

Pretty busy with my full-time gig :)
Just wanted to log it as an idea ;)

Probably the best strategy is to somehow use Gixy's Docker image: https://github.com/yandex/gixy/blob/master/README.md#docker-usage

This way users don't need to have a fully functioning local python setup. Also, "Gixy is well tested only on GNU/Linux, other OSs may have some issues."

LeoColomb commented

Not sure it comes with a real value, but hey, it's here.

  • 🎉1
devinrhode2 commented

I think the greatest value is for consumers that never/almost never modify nginx configs ;)

Since this project passes the linting, this will encourage consumers to also use Gixy. Any issues that come up are clearly caused by their own changes. Maybe they can solve their issue faster, and avoid asking questions on stack overflow/GitHub 😎