h5p/moodle-mod_hvp

Deprecation warnings with PHP 8.2

Opened this issue · 1 comments

As the plugin supports Moodle 4.2 and Moodle 4.2 supports PHP 8.2 then I would expect it to work with PHP 8.2. It throws deprecation notices as follows...

Deprecated: Creation of dynamic property H5PCore::$url is deprecated in /app/public/mod/hvp/library/h5p.classes.php on line 2145

Deprecated: Creation of dynamic property H5PCore::$development_mode is deprecated in /app/public/mod/hvp/library/h5p.classes.php on line 2147

Deprecated: Creation of dynamic property H5PCore::$aggregateAssets is deprecated in /app/public/mod/hvp/library/h5p.classes.php on line 2149

Deprecated: Creation of dynamic property H5PCore::$fullPluginPath is deprecated in /app/public/mod/hvp/library/h5p.classes.php on line 2152

Deprecated: Creation of dynamic property H5PCore::$relativePathRegExp is deprecated in /app/public/mod/hvp/library/h5p.classes.php on line 2155

This would seem to be the following.. https://php.watch/versions/8.2/dynamic-properties-deprecated

Hi @thepurpleblob,
I have the plugin installed on a Moodle 4.3 with PHP 8.2, a test environment, and the plugin (CRON, actually) throws these errors too. Did you notice any actual issues while using the plugin? I wonder what's the effect of this issue.

Although I successfully uploaded an H5P content into the H5P activity that I created, and also successfully edited the content and viewed it, it's possible that there is an issue that I didn't notice yet, issue in the sense of an actual bug in the plugin, and not "only" deprecation messages that are sent by the CRON.