ha-warmup/warmup

run_mode misspelled `overide`

Opened this issue · 2 comments

artmg commented

The value returned by the warmup climate entity when an override is set is misspelt.

overide

should have a double r as per all the object's property names and, er, the dictionary.

The value returned by the API appears to be an int, so to rectify this issue should be as simple as modifying the string value against the key in the dictionary declaration RUN_MODE = { at the start of warmup_cc/warmup4ie/warmup4ie.py. Therefore I'll leave this here for now in case anyone fancies having a crack at this as their first issue to PR and fix.

NB: for users this would be a Breaking Change, IF they rely on a text match with the mispelled text in the sensor template or automation logic, so we need to declare this on release

rct commented

I don't know if it related to this typo/misspelling:

When the thermostat is set to override (boost) outside of Home Assistant, it does not show the mode change correctly in Home Assistant. For me the mode changes to auto during override and back to heat when the override is complete.

artmg commented

@rct if you have this good, definitive test case, would you consider forking the project and making the change suggested in the first post above? If that fixes it then we can PR your change into the main project. Any contributions are very welcome, thanks