ha/doozerd

Clean up logging

Opened this issue · 5 comments

bketelsen commented

Logging is too verbose. Fix logging to make it consistent, possibly add log levels for more verbosity when necessary.

Option: Change log level of running doozerd instances with signals.

srid commented

@mreiferson - we are looking to implement this (high-prio) feature for stackato and send a pull request. i see that this issue is already assigned to you. do you plan to work on your own, or should we collaborate? let me know also if you want me to work on it instead.

specifically, i want to have log levels (debug, info, warn, error) that can be overridden with command line arguments or signals. could possibly build on top of what i already have.

bketelsen commented

+1 on signals - it's what we use in Skynet for changing log levels.

mreiferson commented

Yea, I did start working on this, I'll push my code up.

I like the idea of using signals, too, I'll add that.

I am interested in some feedback as to what is useful information to log in the default (info) case.

srid commented

that's excellent. i'm looking forward to your changes.

what is useful information to log in the default (info) case.

  • log all API calls (GET, SET, WAIT, ..) from the client? perhaps that belongs to the debug level.
  • log cluster related operations (eg: joining of a node)?
mreiferson commented

sounds reasonable, I'll take a pass and we can discuss over code :)