haberdashPI/MetaArrays.jl

Typo "BradcastStyle"?

Closed this issue · 2 comments

dronir commented

I was just reading through the code because I was interested to see how the broadcasting is implemented, and noticed what I assume is a typo.

MetaArrays.jl/src/MetaArrays.jl

Line 190 in bd312ec

MetaArrayStyle(BradcastStyle(A(),B()))

haberdashPI commented

So it is. Thank you for catching it! I have been meaning to improve code coverage, and clearly I haven't tested that line yet. I should be able to get to this within the next few days, but can't fix it at the moment.

haberdashPI commented

Commit 9140cea implements the intended functionality. The failure to properly implement/test this method caused a bug when broadcasting a MetaArray of an array that implemented custom broadcast machinery (e.g. StaticArrays).